Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 428: Remove sh:minCounts to support minimal object definitions #460

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Issue 428: Remove sh:minCounts to support minimal object definitions #460

merged 1 commit into from
Aug 19, 2022

Conversation

ajnelson-nist
Copy link
Contributor

@ajnelson-nist ajnelson-nist commented Aug 19, 2022 •
edited
Loading

This Pull Request resolves all requirements of Issue #428 .

Review steps taken:

  • Pull request is against correct branch
  • CI passes in (CASE/UCO) feature branch
  • CI passes in (CASE/UCO) current unstable branch (49568da)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io (N/A)

@ajnelson-nist
Remove sh:minCounts to support minimal object definitions
6ac11fa 
No effects were observed on Make-managed files.

References:
* #428

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist ajnelson-nist added this to the UCO 1.0.0 milestone Aug 19, 2022
@ajnelson-nist ajnelson-nist linked an issue Aug 19, 2022 that may be closed by this pull request
Change minCount from 1 to 0 on multiple properties #428
Closed
7 tasks
@ajnelson-nist ajnelson-nist changed the title Remove sh:minCounts to support minimal object definitions Issue 428: Remove sh:minCounts to support minimal object definitions Aug 19, 2022
@ajnelson-nist
Copy link
Contributor Author

@eoghanscasey , fyi: I did not apply the observable:message change in MessageThreadFacet because by the time this branch was started, observable:message no longer existed. It was removed as part of #393 .

@ajnelson-nist
Copy link
Contributor Author

ajnelson-nist commented Aug 19, 2022 •
edited
Loading

Also, the ConfigurationSettingType tool:itemValue min. count removal will end up being mooted by Issue #405 and/or Issue #432 . There was a merge conflict for tool.ttl in the unstable branch about this.

@b0bkaT b0bkaT merged commit 1071981 into develop Aug 19, 2022
@ajnelson-nist ajnelson-nist deleted the Feature-Issue-428 branch August 22, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b0bkaT b0bkaT b0bkaT approved these changes

Assignees

@b0bkaT b0bkaT

Labels
None yet
Projects
None yet
Milestone
UCO 1.0.0
Development

Successfully merging this pull request may close these issues.

Change minCount from 1 to 0 on multiple properties
2 participants
@ajnelson-nist @b0bkaT